Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venmo Universal Link Return #1440

Merged
merged 23 commits into from
Dec 4, 2024
Merged

Venmo Universal Link Return #1440

merged 23 commits into from
Dec 4, 2024

Conversation

jaxdesmarais
Copy link
Contributor

@jaxdesmarais jaxdesmarais commented Oct 21, 2024

Summary of changes

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais marked this pull request as ready for review October 21, 2024 15:13
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 21, 2024 15:13
@scannillo
Copy link
Contributor

I think URL schemes on the way back from Venmo was the only remaining need for a merchant to set BTAppContextSwitcher.sharedInstance.returnURLScheme 🥹. Let's deprecate it! 🔥

Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! 🚀

@jaxdesmarais
Copy link
Contributor Author

Adding do not merge while we wait on RCIP approval for merge/release

@scannillo
Copy link
Contributor

scannillo commented Dec 4, 2024

RCIP case 3021997 has been closed. This PR is ready for merge / release.

@jaxdesmarais
Copy link
Contributor Author

Merging in and will be released once moratorium is lifted

@jaxdesmarais jaxdesmarais merged commit 3c6f291 into main Dec 4, 2024
8 checks passed
@jaxdesmarais jaxdesmarais deleted the venmo-universal-link-return branch December 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants